Skip to content

fix: 640 camera with distortion v2 to v4 #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

StefanThoene
Copy link
Collaborator

Description

fix issues with v2 and V4 distortion files

Issue linked

#640

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have assigned this PR to myself.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: add optical property)
  • I have agreed with the Contributor License Agreement (CLA).

@StefanThoene StefanThoene linked an issue Jun 27, 2025 that may be closed by this pull request
2 tasks
@github-actions github-actions bot added the bug Something isn't working label Jun 27, 2025
Copy link

codecov bot commented Jun 27, 2025

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.44%. Comparing base (ef8ff16) to head (7f87b91).

Files with missing lines Patch % Lines
src/ansys/speos/core/sensor.py 90.90% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #644   +/-   ##
=======================================
  Coverage   89.44%   89.44%           
=======================================
  Files          39       39           
  Lines        5522     5544   +22     
=======================================
+ Hits         4939     4959   +20     
- Misses        583      585    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@StefanThoene StefanThoene changed the title Fix/640 camera with distortion v2 to v4 fix: 640 camera with distortion v2 to v4 Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Camera with distortion V2, V2.1 and V4
2 participants