fix: coding error, switch to correct order #601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanThoene
requested review from
pluAtAnsys,
echambla and
jomadec
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #601 +/- ##
=======================================
Coverage 88.51% 88.51%
=======================================
Files 39 39
Lines 4764 4764
=======================================
Hits 4217 4217
Misses 547 547 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jomadec
approved these changes
May 27, 2025
pluAtAnsys
approved these changes
May 27, 2025
StefanThoene
added a commit
that referenced
this pull request
May 28, 2025
## Description issue withj reversed transmission and reflection spectrum ## Issue linked ## Checklist - [ ] I have tested my changes locally. - [ ] I have added necessary documentation or updated existing documentation. - [ ] I have followed the coding style guidelines of this project. - [ ] I have added appropriate tests (unit, integration, system). - [ ] I have reviewed my changes before submitting this pull request. - [ ] I have linked the issue or issues that are solved by the PR if any. - [ ] I have assigned this PR to myself. - [ ] I have made sure that the title of my PR follows [Conventional commits style](https://www.conventionalcommits.org/en/v1.0.0/#summary) (e.g. ``feat: add optical property``) - [ ] I have agreed with the Contributor License Agreement ([CLA](https://developer.ansys.com/form/cla-acceptance)). --------- Co-authored-by: pyansys-ci-bot <[email protected]> (cherry picked from commit c9dd829)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
issue withj reversed transmission and reflection spectrum
Issue linked
Checklist
feat: add optical property)