Skip to content

feat: bsdf #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 75 commits into from
May 26, 2025
Merged

feat: bsdf #581

merged 75 commits into from
May 26, 2025

Conversation

StefanThoene
Copy link
Collaborator

@StefanThoene StefanThoene commented May 9, 2025

Description

Implement bsdf class to allow easy access to bsdf information

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have assigned this PR to myself.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: add optical property)
  • I have agreed with the Contributor License Agreement (CLA).

@github-actions github-actions bot added the enhancement New features or code improvements label May 9, 2025
Copy link

codecov bot commented May 9, 2025

Codecov Report

Attention: Patch coverage is 91.69742% with 45 lines in your changes missing coverage. Please review.

Project coverage is 88.47%. Comparing base (bf8f25b) to head (f67139c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/speos/core/bsdf.py 91.57% 45 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #581      +/-   ##
==========================================
+ Coverage   88.06%   88.47%   +0.40%     
==========================================
  Files          38       39       +1     
  Lines        4173     4710     +537     
==========================================
+ Hits         3675     4167     +492     
- Misses        498      543      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added the testing Anything related to tests label May 21, 2025
@github-actions github-actions bot added the maintenance Package and maintenance related label May 22, 2025
@StefanThoene StefanThoene marked this pull request as ready for review May 22, 2025 12:21
pluAtAnsys
pluAtAnsys previously approved these changes May 22, 2025
@StefanThoene StefanThoene merged commit 8e7cf27 into main May 26, 2025
24 checks passed
@StefanThoene StefanThoene deleted the feat/BSDF branch May 26, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New features or code improvements maintenance Package and maintenance related testing Anything related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to define server message size inside the launch_local_speos_rpc_server
5 participants