Skip to content

fix: unittest update based on bug 1229712 #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2025
Merged

Conversation

StefanThoene
Copy link
Collaborator

@StefanThoene StefanThoene commented May 6, 2025

Description

Adjust unittest so main works again with latest dev image
Bug 1229712 fixed the RPC behaviour which allowed to commit a sensor without sensor sensitivity to be set for everycolor channel. the unit test for the feature used that behavior and failed when using the latest image.

adjusted the order in unit test -> from setting, commiting and testing one by one to setting all then comiting and testing

Issue linked

N/A

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have assigned this PR to myself.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: add optical property)
  • I have agreed with the Contributor License Agreement (CLA).

@github-actions github-actions bot added the bug Something isn't working label May 6, 2025
@StefanThoene
Copy link
Collaborator Author

@pluAtAnsys this will not conflict with you changes i cherry picked you commit so we can fiy the nightly while still reviewing the source changes

@jomadec @echambla please review

@StefanThoene StefanThoene marked this pull request as ready for review May 6, 2025 07:06
Copy link

codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.06%. Comparing base (13de0da) to head (7ea2f55).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #579      +/-   ##
==========================================
- Coverage   88.09%   88.06%   -0.03%     
==========================================
  Files          38       38              
  Lines        4173     4173              
==========================================
- Hits         3676     3675       -1     
- Misses        497      498       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@StefanThoene StefanThoene merged commit b138d45 into main May 6, 2025
31 of 36 checks passed
@StefanThoene StefanThoene deleted the fix-unittests branch May 6, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants