Skip to content

fix: Integration direction display and adjust docstrings #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 30, 2025

Conversation

StefanThoene
Copy link
Collaborator

Description

Fix Documentation of integration direction

Issue linked

#569

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have assigned this PR to myself.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: add optical property)
  • I have agreed with the Contributor License Agreement (CLA).

@StefanThoene StefanThoene added the bug Something isn't working label Apr 28, 2025
@StefanThoene StefanThoene self-assigned this Apr 28, 2025
Copy link

codecov bot commented Apr 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.08%. Comparing base (477e319) to head (5c6602e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #570   +/-   ##
=======================================
  Coverage   88.07%   88.08%           
=======================================
  Files          38       38           
  Lines        4169     4171    +2     
=======================================
+ Hits         3672     3674    +2     
  Misses        497      497           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jomadec
jomadec previously approved these changes Apr 28, 2025
SMoraisAnsys
SMoraisAnsys previously approved these changes Apr 28, 2025
@StefanThoene StefanThoene dismissed stale reviews from SMoraisAnsys and jomadec via 032f534 April 29, 2025 05:45
@StefanThoene StefanThoene merged commit 6446dc7 into main Apr 30, 2025
25 checks passed
@StefanThoene StefanThoene deleted the fix/integration-direction branch April 30, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants