-
Notifications
You must be signed in to change notification settings - Fork 4
refactor: improve type hints #564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #564 +/- ##
=======================================
Coverage 88.08% 88.09%
=======================================
Files 38 38
Lines 4171 4173 +2
=======================================
+ Hits 3674 3676 +2
Misses 497 497 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@SMoraisAnsys is the mypy testing all type hints? |
AFAIK, it does yes. Note that this PR doesn't contain a mypy check in CICD. The current configuration of mypy is light and should be extended to disable mutliple things in order to integrate mypy smoothly. If that's fine with you I'd like this PR to be merged, then I'll open a second one where I gather all the "ignore rules" and add a job in CICD. |
yeah please add the test to the CICD, please also add an issue then i will start working on fixing all errors coming from it and remove ignore rules step by step |
Description
Beginning of changes to improve type hints use and checking them with
mypy
Issue linked
Associated to #481
Checklist
feat: add optical property
)