Skip to content

refactor: improve type hints #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 30, 2025
Merged

Conversation

SMoraisAnsys
Copy link
Contributor

@SMoraisAnsys SMoraisAnsys commented Apr 22, 2025

Description

Beginning of changes to improve type hints use and checking them with mypy

Issue linked

Associated to #481

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have assigned this PR to myself.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: add optical property)
  • I have agreed with the Contributor License Agreement (CLA).

@SMoraisAnsys SMoraisAnsys self-assigned this Apr 22, 2025
@github-actions github-actions bot added the maintenance Package and maintenance related label Apr 22, 2025
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.09%. Comparing base (c85543f) to head (2b16836).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #564   +/-   ##
=======================================
  Coverage   88.08%   88.09%           
=======================================
  Files          38       38           
  Lines        4171     4173    +2     
=======================================
+ Hits         3674     3676    +2     
  Misses        497      497           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@StefanThoene
Copy link
Collaborator

@SMoraisAnsys is the mypy testing all type hints?

@SMoraisAnsys
Copy link
Contributor Author

SMoraisAnsys commented Apr 30, 2025

@SMoraisAnsys is the mypy testing all type hints?

AFAIK, it does yes.

Note that this PR doesn't contain a mypy check in CICD. The current configuration of mypy is light and should be extended to disable mutliple things in order to integrate mypy smoothly. If that's fine with you I'd like this PR to be merged, then I'll open a second one where I gather all the "ignore rules" and add a job in CICD.

@StefanThoene
Copy link
Collaborator

@SMoraisAnsys is the mypy testing all type hints?

AFAIK, it does yes.

Note that this PR doesn't contain a mypy check in CICD. The current configuration of mypy is light and should be extended to disable mutliple things in order to integrate mypy smoothly. If that's fine with you I'd like this PR to be merged, then I'll open a second one where I gather all the "ignore rules" and add a job in CICD.

yeah please add the test to the CICD, please also add an issue then i will start working on fixing all errors coming from it and remove ignore rules step by step

@StefanThoene StefanThoene requested a review from jomadec as a code owner April 30, 2025 13:58
@StefanThoene StefanThoene merged commit 13de0da into main Apr 30, 2025
24 checks passed
@StefanThoene StefanThoene deleted the refactor/improve-type-hints branch April 30, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants