Skip to content

feat: geopath property #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Apr 30, 2025
Merged

feat: geopath property #551

merged 19 commits into from
Apr 30, 2025

Conversation

StefanThoene
Copy link
Collaborator

@StefanThoene StefanThoene commented Apr 14, 2025

Description

provide easy access to geometry path information from part body face instances

Issue linked

#550

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have assigned this PR to myself.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: add optical property)
  • I have agreed with the Contributor License Agreement (CLA).

@github-actions github-actions bot added the enhancement New features or code improvements label Apr 14, 2025
@StefanThoene
Copy link
Collaborator Author

@pluAtAnsys can you please check what i created here before i start creating tests

@StefanThoene StefanThoene linked an issue Apr 15, 2025 that may be closed by this pull request
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

Attention: Patch coverage is 91.30435% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.07%. Comparing base (c57731c) to head (fd4f28d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/speos/core/opt_prop.py 84.61% 2 Missing ⚠️
src/ansys/speos/core/source.py 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #551      +/-   ##
==========================================
+ Coverage   88.05%   88.07%   +0.02%     
==========================================
  Files          38       38              
  Lines        4127     4169      +42     
==========================================
+ Hits         3634     3672      +38     
- Misses        493      497       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@StefanThoene
Copy link
Collaborator Author

@jomadec @echambla can you please have alook before i start reworking the tests and examples

@StefanThoene StefanThoene marked this pull request as ready for review April 29, 2025 06:19
@StefanThoene StefanThoene requested a review from echambla as a code owner April 29, 2025 06:19
@StefanThoene StefanThoene merged commit 477e319 into main Apr 30, 2025
25 checks passed
@StefanThoene StefanThoene deleted the feat/geopath-property branch April 30, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add access to Native GeoPath for each Face/Body object
4 participants