Skip to content

chore: Rename CONTRUBUTORS.md to CONTRIBUTORS.md #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 14, 2025

Conversation

StefanThoene
Copy link
Collaborator

Description

Fix typo in Contributor.md

(cherry picked from commit c4cae54)

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have assigned this PR to myself.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: add optical property)
  • I have agreed with the Contributor License Agreement (CLA).

@SMoraisAnsys
Copy link
Contributor

Thanks @ThomasAuzinger a lot for the contribution. We had to open a new PR with your changes because forks cannot run successfully some of our CI's jobs. For example, running the tests or documentation build leverage Github secrets to access license information. However, this is only available from the ansys organization.
Nonetheless, this PR contains your changes and they have been cherry-picked manually. You remain the author of said changes, Stefan is only the commiter (with write access to the repo).

Copy link

codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.83%. Comparing base (b687dde) to head (5a0f957).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #548   +/-   ##
=======================================
  Coverage   86.83%   86.83%           
=======================================
  Files          35       35           
  Lines        3843     3843           
=======================================
  Hits         3337     3337           
  Misses        506      506           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@StefanThoene StefanThoene marked this pull request as ready for review April 14, 2025 11:45
ThomasAuzinger added a commit to ThomasAuzinger/ansys-api-speos that referenced this pull request Apr 14, 2025
@ThomasAuzinger
Copy link
Contributor

See also ansys/ansys-api-speos#98

@StefanThoene StefanThoene merged commit a768f91 into main Apr 14, 2025
24 checks passed
@StefanThoene StefanThoene deleted the chore/fix-typo-contributors branch April 14, 2025 13:29
echambla pushed a commit to ansys/ansys-api-speos that referenced this pull request Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants