generated from ansys/template
-
Notifications
You must be signed in to change notification settings - Fork 4
fix: improve examples and tests due to more errors raised by the new SpeosRPC server #546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix test
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #546 +/- ##
==========================================
- Coverage 86.87% 86.83% -0.05%
==========================================
Files 35 35
Lines 3840 3843 +3
==========================================
+ Hits 3336 3337 +1
- Misses 504 506 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
echambla
previously approved these changes
Apr 11, 2025
SMoraisAnsys
previously approved these changes
Apr 11, 2025
87e0d3a
SMoraisAnsys
approved these changes
Apr 11, 2025
pluAtAnsys
approved these changes
Apr 11, 2025
echambla
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adapt to new Speos RPC server behavior.
More errors are raised when objects committed are not correct.
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist
feat: add optical property
)