Skip to content

fix: improve examples and tests due to more errors raised by the new SpeosRPC server #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 11, 2025

Conversation

StefanThoene
Copy link
Collaborator

@StefanThoene StefanThoene commented Apr 10, 2025

Description

Adapt to new Speos RPC server behavior.
More errors are raised when objects committed are not correct.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have assigned this PR to myself.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: add optical property)
  • I have agreed with the Contributor License Agreement (CLA).

@StefanThoene StefanThoene changed the title fix optical property issue fix: optical property issue Apr 10, 2025
@github-actions github-actions bot added the bug Something isn't working label Apr 10, 2025
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.83%. Comparing base (9064b19) to head (87e0d3a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #546      +/-   ##
==========================================
- Coverage   86.87%   86.83%   -0.05%     
==========================================
  Files          35       35              
  Lines        3840     3843       +3     
==========================================
+ Hits         3336     3337       +1     
- Misses        504      506       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@StefanThoene StefanThoene marked this pull request as ready for review April 11, 2025 08:39
echambla
echambla previously approved these changes Apr 11, 2025
SMoraisAnsys
SMoraisAnsys previously approved these changes Apr 11, 2025
@StefanThoene StefanThoene self-assigned this Apr 11, 2025
@echambla echambla changed the title fix: optical property issue fix: improve examples and tests due to more errors raised by the new SpeosRPC server Apr 11, 2025
@pyansys-ci-bot pyansys-ci-bot dismissed stale reviews from SMoraisAnsys and echambla via 87e0d3a April 11, 2025 09:18
@pluAtAnsys pluAtAnsys merged commit 56380df into main Apr 11, 2025
24 checks passed
@pluAtAnsys pluAtAnsys deleted the fix/opt_prop branch April 11, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants