Skip to content

fix: issue with nightly pipeline #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 2, 2025
Merged

fix: issue with nightly pipeline #534

merged 3 commits into from
Apr 2, 2025

Conversation

StefanThoene
Copy link
Collaborator

@StefanThoene StefanThoene commented Apr 2, 2025

Description

forgot to update noghtly on direct test wher updated

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have assigned this PR to myself.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: add optical property)
  • I have agreed with the Contributor License Agreement (CLA).

@github-actions github-actions bot added maintenance Package and maintenance related bug Something isn't working labels Apr 2, 2025
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.81%. Comparing base (cc9ab8e) to head (d82b866).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #534   +/-   ##
=======================================
  Coverage   86.81%   86.81%           
=======================================
  Files          35       35           
  Lines        3846     3846           
=======================================
  Hits         3339     3339           
  Misses        507      507           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I took the liberty to add the missing OS packages.

@StefanThoene
Copy link
Collaborator Author

LGTM, I took the liberty to add the missing OS packages.

thank you

@StefanThoene StefanThoene self-assigned this Apr 2, 2025
@StefanThoene StefanThoene merged commit cfc9caf into main Apr 2, 2025
30 of 42 checks passed
@StefanThoene StefanThoene deleted the fix/nightly branch April 2, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants