Skip to content

feat: enhance the project preview: irrad, rad, camera sensor features #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 41 commits into from
Apr 16, 2025

Conversation

pluAtAnsys
Copy link
Collaborator

@pluAtAnsys pluAtAnsys commented Mar 29, 2025

Description

Please provide a brief description of the changes made in this pull request.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have assigned this PR to myself.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: add optical property)
  • I have agreed with the Contributor License Agreement (CLA).

@pluAtAnsys pluAtAnsys self-assigned this Mar 29, 2025
@github-actions github-actions bot added the enhancement New features or code improvements label Mar 29, 2025
@pluAtAnsys pluAtAnsys closed this Mar 29, 2025
@pluAtAnsys pluAtAnsys reopened this Mar 29, 2025
@pluAtAnsys pluAtAnsys marked this pull request as draft March 29, 2025 17:23
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

Attention: Patch coverage is 94.70899% with 10 lines in your changes missing coverage. Please review.

Project coverage is 88.05%. Comparing base (cb589c9) to head (69e786b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../ansys/speos/core/generic/visualization_methods.py 89.39% 7 Missing ⚠️
src/ansys/speos/core/generic/general_methods.py 85.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #528      +/-   ##
==========================================
+ Coverage   87.42%   88.05%   +0.63%     
==========================================
  Files          37       38       +1     
  Lines        3943     4127     +184     
==========================================
+ Hits         3447     3634     +187     
+ Misses        496      493       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pluAtAnsys pluAtAnsys linked an issue Apr 2, 2025 that may be closed by this pull request
@pluAtAnsys pluAtAnsys requested a review from StefanThoene April 10, 2025 08:29
Copy link
Contributor

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking into account the previous comments @pluAtAnsys
I left some other comments

@pluAtAnsys pluAtAnsys requested a review from SMoraisAnsys April 15, 2025 11:39
echambla
echambla previously approved these changes Apr 15, 2025
Copy link
Contributor

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still a conversation that needs to be handled (currently marked as solved but nothing has been performed to match the request).

Also, quick question: do we need to add the graphics_required decorator for methods that do not directly import pyvista ? Would it be better to delegate that to the inner calls of the functions ? For example, having add_data_triangle raise the exception through the decorator and not decorating visual_data ?

@pluAtAnsys
Copy link
Collaborator Author

There is still a conversation that needs to be handled (currently marked as solved but nothing has been performed to match the request).

Also, quick question: do we need to add the graphics_required decorator for methods that do not directly import pyvista ? Would it be better to delegate that to the inner calls of the functions ? For example, having add_data_triangle raise the exception through the decorator and not decorating visual_data ?

that is true. I forgot to remove that decorator as now that is handled inside the visualization_methods.py

SMoraisAnsys
SMoraisAnsys previously approved these changes Apr 16, 2025
Copy link
Contributor

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

StefanThoene
StefanThoene previously approved these changes Apr 16, 2025
@pluAtAnsys pluAtAnsys merged commit 60cde86 into main Apr 16, 2025
24 checks passed
@pluAtAnsys pluAtAnsys deleted the feat/preview_sensor branch April 16, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve project preview: sensor
5 participants