Skip to content

ci: remove code-style job to use precommit.ci #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 28, 2025

Conversation

SMoraisAnsys
Copy link
Contributor

@SMoraisAnsys SMoraisAnsys commented Mar 27, 2025

Description

The code-style action is mainly used for ansys internal package. Once public, a repo can leverage the precommit.ci Github app and I just added it to the repo. When one doesn't follow the code style, a bot should be coming and performing the required changes or fail the workflow.

Here is a snapshot of the current checks
image

Issue linked

None

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have assigned this PR to myself.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: add optical property)
  • I have agreed with the Contributor License Agreement (CLA).

@github-actions github-actions bot added the maintenance Package and maintenance related label Mar 27, 2025
@SMoraisAnsys
Copy link
Contributor Author

@StefanThoene I'll remove the check on "code style" and add the precommit.ci one once the review is "accepted"

@SMoraisAnsys SMoraisAnsys enabled auto-merge (squash) March 28, 2025 10:24
@SMoraisAnsys SMoraisAnsys merged commit f9e1258 into main Mar 28, 2025
25 checks passed
@SMoraisAnsys SMoraisAnsys deleted the ci/remove-code-style branch March 28, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants