feat: add screenshot in pyvista related methods #521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SMoraisAnsys
changed the title
|
i will integrate it in my PR |
|
@StefanThoene Reopening for testing purposes |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
SMoraisAnsys
changed the title
SMoraisAnsys
requested review from
StefanThoene,
pluAtAnsys and
echambla
as code owners
9 tasks
SMoraisAnsys
commented
Mar 28, 2025
pluAtAnsys
reviewed
Mar 28, 2025
SMoraisAnsys
commented
Mar 28, 2025
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
StefanThoene
approved these changes
Apr 1, 2025
2 tasks
pluAtAnsys
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding
screenshotoption topreviewmethods. On top of it, the CI and test configuration has been updated to allow this kind of test to without issues. This will allow us to increase the code coverage !!!Issue linked
None
Checklist
feat: add optical property)Previous PR content, kept for visibility
To increase code coverage (and fix bugs, see #520) this PR starts to add test(s) on a method using pyvista rendering.Three options are available to do so:leverage an external github action to use headless display;use the python package(https://docs.vtk.org/en/latest/advanced/available_python_wheels.html);vtk-osmesafrom vtk, see [available python wheels]patch the call toshowso that we don't really trigger them.While I like the two first options as they would let us really test everything, they also come with a security risk as we don't maintain the solution associated (tbh, I see little risk in using them though). Therefore, I'm following the third option. Depending on what you think about this, we could make this PR evolve.