Skip to content

docs: add example assets button #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 27, 2025
Merged

docs: add example assets button #518

merged 10 commits into from
Mar 27, 2025

Conversation

SMoraisAnsys
Copy link
Contributor

@SMoraisAnsys SMoraisAnsys commented Mar 26, 2025

Description

Adding a button to download the examples assets. I had too add a work around to ensure that the 3 download buttons were aligned somehow "correctly". See the result below

image

If that's fine with you, we can leave it like that for the moment as we have to test that assets are correctly uploaded and available for download through the documentation. A next step (PR) could be to remove the buttons and only use text content with hyperlinks to trigger the downloading of files.

Issue linked

Related to #497
Close #517

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have assigned this PR to myself.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: add optical property)
  • I have agreed with the Contributor License Agreement (CLA).

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 26, 2025
@SMoraisAnsys SMoraisAnsys self-assigned this Mar 26, 2025
@SMoraisAnsys SMoraisAnsys marked this pull request as ready for review March 26, 2025 14:42
StefanThoene
StefanThoene previously approved these changes Mar 26, 2025
@StefanThoene StefanThoene self-requested a review March 26, 2025 15:58
StefanThoene
StefanThoene previously approved these changes Mar 27, 2025
@StefanThoene
Copy link
Collaborator

@SMoraisAnsys i renamed the path in all examples to assets_data_path so its more clear
can be merged from my perspective

@StefanThoene StefanThoene merged commit e0394e3 into main Mar 27, 2025
27 checks passed
@StefanThoene StefanThoene deleted the docs/add-example-assets branch March 27, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: link asset with example
4 participants