Skip to content

refactor: ruff n #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Mar 21, 2025
Merged

refactor: ruff n #507

merged 20 commits into from
Mar 21, 2025

Conversation

StefanThoene
Copy link
Collaborator

Description

*Improve code style by removing ruff N ignores from pyproject.toml

Issue linked

#479

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have assigned this PR to myself.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: add optical property)
  • I have agreed with the Contributor License Agreement (CLA).

@StefanThoene StefanThoene self-assigned this Mar 19, 2025
@StefanThoene StefanThoene linked an issue Mar 19, 2025 that may be closed by this pull request
@github-actions github-actions bot added maintenance Package and maintenance related testing Anything related to tests labels Mar 19, 2025
@StefanThoene StefanThoene marked this pull request as ready for review March 19, 2025 15:28
SMoraisAnsys
SMoraisAnsys previously approved these changes Mar 20, 2025
Copy link
Contributor

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to keep using capital letters to define "constant" variables, you might want to either:

  • deactivate N806 globally in the config file;
  • add skip comment # noqa: N806 when such variables are defined

IMO keeping full capital variables when dealing with constant variables is a good thing and I would recommend it. Note that this would require to revert some changes, e.g. LOG, R, G, ``B`

add arguments decorator to allow argument renaming
refactor deprecation warnings
@StefanThoene StefanThoene enabled auto-merge (squash) March 21, 2025 14:15
@StefanThoene StefanThoene merged commit 49320a6 into main Mar 21, 2025
25 checks passed
@StefanThoene StefanThoene deleted the refactor/ruff-N branch March 21, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Package and maintenance related testing Anything related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove ruff ignore "N", # pep8-naming
4 participants