-
Notifications
You must be signed in to change notification settings - Fork 4
refactor: ruff n #507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: ruff n #507
Conversation
for intensity.py
for simulation.py
for spectrum.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to keep using capital letters to define "constant" variables, you might want to either:
- deactivate N806 globally in the config file;
- add skip comment
# noqa: N806
when such variables are defined
IMO keeping full capital variables when dealing with constant variables is a good thing and I would recommend it. Note that this would require to revert some changes, e.g. LOG
, R
, G
, ``B`
add arguments decorator to allow argument renaming refactor deprecation warnings
Description
*Improve code style by removing ruff N ignores from pyproject.toml
Issue linked
#479
Checklist
feat: add optical property
)