Skip to content

fix: core layer loading a camera sensor #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 17, 2025
Merged

Conversation

pluAtAnsys
Copy link
Collaborator

@pluAtAnsys pluAtAnsys commented Mar 15, 2025

Description

In the Core layer, when loading a speos file which contains camera sensor, a SensorRadiance type is created rather than SensorCamera.

Issue linked

502

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have assigned this PR to myself.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: add optical property)
  • I have agreed with the Contributor License Agreement (CLA).

@pluAtAnsys pluAtAnsys self-assigned this Mar 15, 2025
@pluAtAnsys pluAtAnsys linked an issue Mar 15, 2025 that may be closed by this pull request
2 tasks
@github-actions github-actions bot added the bug Something isn't working label Mar 15, 2025
@pluAtAnsys pluAtAnsys merged commit 368f1a5 into main Mar 17, 2025
27 checks passed
@pluAtAnsys pluAtAnsys deleted the fix-load-camera-feature branch March 17, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Camera sensor in speos file is loaded as SensorRadiance
3 participants