Skip to content

docs: Update example combine-speos.py #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Apr 4, 2025

Conversation

Devin-Crawford
Copy link
Contributor

  • Use constants to define re-used values.
  • Improve readability
  • Remove os.path dependency in favor of Path()

Description

Readability and syntax improvements in the example.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have assigned this PR to myself.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: add optical property)
  • I have agreed with the Contributor License Agreement (CLA).

- Use constants to define re-used values.
- Make formatting a bit more "Pythonic"
- Remove os.path dependency in favor of Path()
@Devin-Crawford Devin-Crawford changed the title DOC: Update example combine-speos.py DOCS: Update example combine-speos.py Mar 15, 2025
@StefanThoene StefanThoene changed the title DOCS: Update example combine-speos.py docs: Update example combine-speos.py Mar 18, 2025
StefanThoene
StefanThoene previously approved these changes Mar 19, 2025
SMoraisAnsys
SMoraisAnsys previously approved these changes Apr 2, 2025
Copy link
Contributor

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left minor comments

@StefanThoene StefanThoene dismissed stale reviews from SMoraisAnsys and themself via bd2b58a April 2, 2025 13:51
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.87%. Comparing base (d3ed397) to head (7ae6be6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #499   +/-   ##
=======================================
  Coverage   86.87%   86.87%           
=======================================
  Files          35       35           
  Lines        3840     3840           
=======================================
  Hits         3336     3336           
  Misses        504      504           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

StefanThoene
StefanThoene previously approved these changes Apr 3, 2025
Copy link
Contributor

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't define CAR_CS as it is since it is first defined as {} then updated with constant. Either call the variable car_cs or define CAR_CS = { .... } and only access to it in "read" mode later.

@StefanThoene StefanThoene self-requested a review April 3, 2025 14:50
@StefanThoene StefanThoene self-requested a review April 3, 2025 16:47
@StefanThoene
Copy link
Collaborator

@SMoraisAnsys @Devin-Crawford can you please have a look if everything is fine now?

Copy link
Contributor

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for performing the changes @StefanThoene

@StefanThoene StefanThoene merged commit b06e3b6 into main Apr 4, 2025
24 checks passed
@StefanThoene StefanThoene deleted the update/example_combine_speos branch April 4, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants