-
Notifications
You must be signed in to change notification settings - Fork 4
docs: Update example combine-speos.py #499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Use constants to define re-used values. - Make formatting a bit more "Pythonic" - Remove os.path dependency in favor of Path()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I left minor comments
# Conflicts: # examples/workflow/combine-speos.py
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #499 +/- ##
=======================================
Coverage 86.87% 86.87%
=======================================
Files 35 35
Lines 3840 3840
=======================================
Hits 3336 3336
Misses 504 504 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't define CAR_CS
as it is since it is first defined as {}
then updated with constant. Either call the variable car_cs
or define CAR_CS = { .... }
and only access to it in "read" mode later.
define CAR_CS as Constant
for more information, see https://pre-commit.ci
fix cs values
for more information, see https://pre-commit.ci
@SMoraisAnsys @Devin-Crawford can you please have a look if everything is fine now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for performing the changes @StefanThoene
Description
Readability and syntax improvements in the example.
Checklist
feat: add optical property
)