Skip to content

refactor: remove ruff E ignores #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 18, 2025
Merged

refactor: remove ruff E ignores #495

merged 10 commits into from
Mar 18, 2025

Conversation

StefanThoene
Copy link
Collaborator

@StefanThoene StefanThoene commented Mar 11, 2025 •
edited
Loading

Description

Refactor code so ignored ruff rules don't provide errors an remove said rules from ignore list

Issue linked

#477

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have assigned this PR to myself.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: add optical property)
  • I have agreed with the Contributor License Agreement (CLA).

@StefanThoene StefanThoene added enhancement New features or code improvements maintenance Package and maintenance related labels Mar 11, 2025
@StefanThoene StefanThoene self-assigned this Mar 11, 2025
@StefanThoene StefanThoene linked an issue Mar 11, 2025 that may be closed by this pull request
remove ruff ignore "E", # pycodestyle #477
Closed
@StefanThoene StefanThoene marked this pull request as ready for review March 11, 2025 13:21
@github-actions github-actions bot added documentation Improvements or additions to documentation testing Anything related to tests labels Mar 11, 2025
echambla
echambla reviewed Mar 18, 2025
View reviewed changes
StefanThoene
StefanThoene commented Mar 18, 2025
View reviewed changes
@StefanThoene StefanThoene merged commit 585e9ba into main Mar 18, 2025
27 checks passed
@StefanThoene StefanThoene deleted the refactor/ruff-E branch March 18, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echambla echambla echambla approved these changes

@etiennearnal etiennearnal Awaiting requested review from etiennearnal etiennearnal is a code owner

@jomadec jomadec Awaiting requested review from jomadec jomadec is a code owner

@pluAtAnsys pluAtAnsys Awaiting requested review from pluAtAnsys pluAtAnsys is a code owner

Assignees

@StefanThoene StefanThoene

Labels
documentation Improvements or additions to documentation enhancement New features or code improvements maintenance Package and maintenance related testing Anything related to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove ruff ignore "E", # pycodestyle
3 participants
@StefanThoene @echambla @pyansys-ci-bot