Skip to content

refactor: Remove ruff ignore for "D", pydocstyle #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Mar 5, 2025
Merged

Conversation

StefanThoene
Copy link
Collaborator

@StefanThoene StefanThoene commented Feb 26, 2025

Description

Remove ruff ignore for "D", pydocstyle

Issue linked

#476

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have assigned this PR to myself.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: add optical property)
  • I have agreed with the Contributor License Agreement (CLA).

@StefanThoene StefanThoene linked an issue Feb 26, 2025 that may be closed by this pull request
@StefanThoene StefanThoene self-assigned this Feb 26, 2025
@StefanThoene StefanThoene changed the title Refactor/ruff d refactor: Remove ruff ignore for "D", pydocstyle Feb 26, 2025
@github-actions github-actions bot added maintenance Package and maintenance related testing Anything related to tests labels Feb 26, 2025
@StefanThoene StefanThoene added the documentation Improvements or additions to documentation label Feb 26, 2025
@StefanThoene StefanThoene marked this pull request as ready for review February 27, 2025 06:58
SMoraisAnsys
SMoraisAnsys previously approved these changes Feb 27, 2025
Copy link
Contributor

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left a few minor comments though. One is duplicated and I didn't track all occurrences. So, if you want to homogenize things and follow the proposed changes, you'll have to track them on the repo to catch them all.

Thanks for performing those changes, it will greatly enhance the documentation !

pluAtAnsys
pluAtAnsys previously approved these changes Feb 27, 2025
@StefanThoene StefanThoene dismissed stale reviews from pluAtAnsys and SMoraisAnsys via 14cca95 February 28, 2025 07:48
@SMoraisAnsys SMoraisAnsys merged commit 992e164 into main Mar 5, 2025
27 checks passed
@SMoraisAnsys SMoraisAnsys deleted the refactor/ruff-D branch March 5, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation maintenance Package and maintenance related testing Anything related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove ruff ignore "D", # pydocstyle
6 participants