-
Notifications
You must be signed in to change notification settings - Fork 4
refactor: remove ignores for PTH #474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two remarks:
- Would it be possible to directly us
Path(...) / "..."
instead ofPath().joinpath(...)
? In fact I would avoid using joinpath to ease readability (however there might be a reason to keep it that I'm not aware of). - Could the core modules be updated to accept
str
orPath
instead ofstr
only ? You could then cast toPath
automaticaly to handle bothstr
andPath
and, when needed, return tostr
, e.g. when calling stubs
yes it is possible but that would be a second PR/issue it would mean a lot of small changes would be needed in regards to the first i can do that |
Co-authored-by: Sébastien Morais <[email protected]>
Ok, I'll let you handle that later on then :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks handling that task !
Description
Move from os.path to pathlib.Path, to full fill ruff PTH requirements
Issue linked
#475
Checklist
feat: add optical property
)