Skip to content

feat: Feat/add local launcher #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 51 commits into from
Apr 15, 2025
Merged

feat: Feat/add local launcher #454

merged 51 commits into from
Apr 15, 2025

Conversation

StefanThoene
Copy link
Collaborator

@StefanThoene StefanThoene commented Feb 13, 2025

Description

Provide local launcher method

Issue linked

#410

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have assigned this PR to myself.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: add optical property)
  • I have agreed with the Contributor License Agreement (CLA).

@github-actions github-actions bot added maintenance Package and maintenance related enhancement New features or code improvements labels Feb 13, 2025
@StefanThoene
Copy link
Collaborator Author

@echambla @pluAtAnsys @jomadec do we want to add this before the release?

@pluAtAnsys
Copy link
Collaborator

I am a bit hesitate here due to large magick method refactor (maybe?)

@StefanThoene StefanThoene self-assigned this Mar 24, 2025
@StefanThoene StefanThoene linked an issue Mar 24, 2025 that may be closed by this pull request
@StefanThoene
Copy link
Collaborator Author

@pluAtAnsys can oyu have a look?

we also need to think on how to test it?

add simple test
@github-actions github-actions bot added the testing Anything related to tests label Mar 25, 2025
@StefanThoene StefanThoene marked this pull request as ready for review April 8, 2025 14:45
@StefanThoene
Copy link
Collaborator Author

@pluAtAnsys could you have a look?

it might also make sense to have a look at the documentation for the launch Speos RPC part
or do you think we should do that in a seperate PR

Copy link
Contributor

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments, we can discuss about them on a call if you want.

pluAtAnsys
pluAtAnsys previously approved these changes Apr 11, 2025
@StefanThoene
Copy link
Collaborator Author

@pluAtAnsys great comments i adjusted the code based on the review

SMoraisAnsys
SMoraisAnsys previously approved these changes Apr 14, 2025
Copy link
Contributor

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left some last comments

@StefanThoene StefanThoene merged commit a0dd358 into main Apr 15, 2025
28 checks passed
@StefanThoene StefanThoene deleted the feat/add-local-launcher branch April 15, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements maintenance Package and maintenance related testing Anything related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Launch local Service Method to launcher
5 participants