-
Notifications
You must be signed in to change notification settings - Fork 4
feat: Feat/add local launcher #454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
move close method to SpeosClient class add/adjust close() method in client.py and speos.py
improve close method
@echambla @pluAtAnsys @jomadec do we want to add this before the release? |
I am a bit hesitate here due to large magick method refactor (maybe?) |
@pluAtAnsys can oyu have a look? we also need to think on how to test it? |
add simple test
add simple test
remove test from docker
@pluAtAnsys could you have a look? it might also make sense to have a look at the documentation for the launch Speos RPC part |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments, we can discuss about them on a call if you want.
@pluAtAnsys great comments i adjusted the code based on the review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I left some last comments
Co-authored-by: Sébastien Morais <[email protected]>
Description
Provide local launcher method
Issue linked
#410
Checklist
feat: add optical property
)