Skip to content

Modify versions in requirements and toml files to have == instead of >= #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 26, 2022
Merged

Modify versions in requirements and toml files to have == instead of >= #33

merged 5 commits into from
Aug 26, 2022

Conversation

echambla
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added dependencies Related with project dependencies maintenance Package and maintenance related labels Aug 26, 2022
Revathyvenugopal162
Revathyvenugopal162 reviewed Aug 26, 2022
View reviewed changes
Copy link
Collaborator

@Revathyvenugopal162 Revathyvenugopal162 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the latest version to avoid PR for existing versions from dependabot

@echambla
Copy link
Collaborator Author

@Revathyvenugopal162
Should I also add "flit_core == 3.2" in requirements_build.txt ?
Currently it is only in toml file [build-system] requires

@Revathyvenugopal162
Copy link
Collaborator

@Revathyvenugopal162 Should I also add "flit_core == 3.2" in requirements_build.txt ? Currently it is only in toml file [build-system] requires

It is not required. it is to build the package with toml. it is not necessary to be in requirements_build.txt

@echambla
Copy link
Collaborator Author

@Revathyvenugopal162 Should I also add "flit_core == 3.2" in requirements_build.txt ? Currently it is only in toml file [build-system] requires

It is not required. it is to build the package with toml. it is not necessary to be in requirements_build.txt

Ok understood, thank you!

@echambla echambla merged commit bad6243 into main Aug 26, 2022
@echambla echambla deleted the maint/requirements_versions branch August 26, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Revathyvenugopal162 Revathyvenugopal162 Revathyvenugopal162 approved these changes

Assignees
No one assigned
Labels
dependencies Related with project dependencies maintenance Package and maintenance related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@echambla @Revathyvenugopal162