feat: add ansys-api-speos as private dependency. #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
maintenance
|
@Revathyvenugopal162 and @MaxJPRey I am wondering why the 1.52.0 was retrieved: |
MaxJPRey
reviewed
Mar 10, 2023
MaxJPRey
reviewed
Mar 10, 2023
.github/workflows/ci_cd.yml
Outdated
| @@ -77,7 +72,7 @@ jobs: | |||
| python -m twine check dist/* | |||
|
|
|||
| - name: Install library | |||
| run: pip install . | |||
| run: pip install -e . | |||
There was a problem hiding this comment.
Is editable mode mandatory?
I know we had to use it in the past to overcome some limitations but not sure it is required here.
Co-authored-by: Maxime Rey <[email protected]>
MaxJPRey
approved these changes
Mar 13, 2023
There was a problem hiding this comment.
Thanks @Revathyvenugopal162 . This is great to move forward with the release and distribution.
etiennearnal
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ansys-api-speos package as private dependency.