-
Notifications
You must be signed in to change notification settings - Fork 23
FEAT: Add option for pep8 aliases in binding #1234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (80.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1234 +/- ##
==========================================
- Coverage 86.40% 86.39% -0.01%
==========================================
Files 39 39
Lines 2537 2544 +7
==========================================
+ Hits 2192 2198 +6
- Misses 345 346 +1 🚀 New features to boost your workflow:
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the opt-out section looks wrong to me
This pull request refactors the
_bind_assembly_for_explicit_interface
function to make it more flexible and updates its usage in theinitialize
function. The refactored function now supports additional options for binding assemblies, including enabling PEP 8 aliases.Refactoring of
_bind_assembly_for_explicit_interface
:_bind_assembly_for_explicit_interface
to_bind_assembly
and added two optional parameters:explicit_interface
andpep8_aliases
. This allows the function to handle both explicit interface implementation and PEP 8 aliasing.AllowExplicitInterfaceImplementation
andPep8Aliases
based on the new parameters.Updates to
initialize
function:_bind_assembly_for_explicit_interface
with_bind_assembly
and passedTrue
for bothexplicit_interface
andpep8_aliases
arguments to enable these features for the "Ansys.ACT.WB1" assembly.Usage: