Skip to content

ci: adapting workflow for new docker container #3805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Apr 1, 2025

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Mar 18, 2025

Description

As the title.

Issue linked

NA

Checklist

@germa89 germa89 requested a review from a team as a code owner March 18, 2025 20:27
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc) labels Mar 18, 2025
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.44%. Comparing base (16508b7) to head (d11b39c).
Report is 1 commits behind head on main.

❌ Your patch status has failed because the patch coverage (66.66%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3805   +/-   ##
=======================================
  Coverage   88.44%   88.44%           
=======================================
  Files         187      187           
  Lines       14751    14751           
=======================================
  Hits        13046    13046           
  Misses       1705     1705           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@germa89
Copy link
Collaborator Author

germa89 commented Mar 28, 2025

local:latest-ubuntu is failing because Github runners are AMD CPUs, and the AMD support is stripped from the standard MAPDL docker image flavour.

I am preparing the new flavour amd.

@germa89
Copy link
Collaborator Author

germa89 commented Mar 30, 2025

Also, it seems that OPENMPI does not allow you to run as user:

--------------------------------------------------------------------------
mpirun has detected an attempt to run as root.

Running as root is *strongly* discouraged as any mistake (e.g., in
defining TMPDIR) or bug can result in catastrophic damage to the OS
file system, leaving your system in an unusable state.

We strongly suggest that you run mpirun as a non-root user.

You can override this protection by adding the --allow-run-as-root option
to the cmd line or by setting two environment variables in the following way:
the variable OMPI_ALLOW_RUN_AS_ROOT=1 to indicate the desire to override this
protection, and OMPI_ALLOW_RUN_AS_ROOT_CONFIRM=1 to confirm the choice and
add one more layer of certainty that you want to do so.
We reiterate our advice against doing so - please proceed at your own risk.
--------------------------------------------------------------------------

It seems that those env vars are not set properly in the bashrc file in the container.

@germa89
Copy link
Collaborator Author

germa89 commented Mar 30, 2025

Upload to coverage does not work because it needs git on the docker image

@germa89
Copy link
Collaborator Author

germa89 commented Apr 1, 2025

I'm going to ignore code coverage here since the introduced code changes are more cosmetic (typing) than anything else.

@pyansys-ci-bot LGTM.

@germa89 germa89 self-assigned this Apr 1, 2025
@germa89 germa89 enabled auto-merge (squash) April 1, 2025 10:09
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit 3ef6c5e into main Apr 1, 2025
51 of 52 checks passed
@germa89 germa89 deleted the ci/adapting-workflow-for-MAPDL-docker-builder branch April 1, 2025 10:09
@germa89 germa89 mentioned this pull request Apr 23, 2025
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants