Skip to content

feat: implement ignore cache reset context #3778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Mar 4, 2025

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Mar 3, 2025

Description

The idea is to make the code more resistant to crashes since we ensure we are switching back to previous state. It can also help to speed up some tests.

Issue linked

NA

Checklist

@germa89 germa89 requested a review from a team as a code owner March 3, 2025 13:39
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Mar 3, 2025
@github-actions github-actions bot added the new feature Request or proposal for a new feature label Mar 3, 2025
@germa89 germa89 enabled auto-merge (squash) March 3, 2025 22:52
@germa89
Copy link
Collaborator Author

germa89 commented Mar 3, 2025

@pyansys-ci-bot LGTM.

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

Attention: Patch coverage is 90.90909% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.35%. Comparing base (9b11862) to head (825d2e9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3778   +/-   ##
=======================================
  Coverage   88.34%   88.35%           
=======================================
  Files         187      187           
  Lines       14717    14733   +16     
=======================================
+ Hits        13002    13017   +15     
- Misses       1715     1716    +1     

@germa89 germa89 merged commit 500043e into main Mar 4, 2025
47 checks passed
@germa89 germa89 deleted the feat/adding-ignore-reset-cache-context-manager branch March 4, 2025 09:57
@germa89 germa89 mentioned this pull request May 7, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants