Skip to content

fix: avoid returning output when using input grpc method #3759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 25, 2025

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Feb 21, 2025

Description

Just checking

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

@germa89 germa89 self-assigned this Feb 21, 2025
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Issue, problem or error in PyMAPDL label Feb 21, 2025
@germa89 germa89 changed the title fix/avoid returning output using input grpc method fix: avoid returning output using input grpc method Feb 21, 2025
@germa89 germa89 changed the title fix: avoid returning output using input grpc method fix: avoid returning output when using input grpc method Feb 21, 2025
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.34%. Comparing base (4c6e65a) to head (c320746).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3759      +/-   ##
==========================================
- Coverage   88.35%   88.34%   -0.01%     
==========================================
  Files         187      187              
  Lines       14704    14719      +15     
==========================================
+ Hits        12991    13003      +12     
- Misses       1713     1716       +3     

@germa89 germa89 marked this pull request as ready for review February 25, 2025 11:13
@germa89 germa89 requested a review from a team as a code owner February 25, 2025 11:13
@germa89
Copy link
Collaborator Author

germa89 commented Feb 25, 2025

@pyansys-ci-bot LGTM.

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit e3ac541 into main Feb 25, 2025
51 checks passed
@germa89 germa89 deleted the fix/avoid-returning-output-using-grpc-method branch February 25, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue, problem or error in PyMAPDL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants