fix: allow numpy types for parameters #3720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germa89
requested review from
koubaa and
mikerife
and removed request for
clatapie and
pyansys-ci-bot
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
10 tasks
…for-parameters' of https://github.com/ansys/pymapdl into fix/numpy-types-for-parameters
|
@pyansys-ci-bot LGTM. |
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (81.81%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #3720 +/- ##
==========================================
- Coverage 88.13% 88.09% -0.04%
==========================================
Files 187 187
Lines 14707 14709 +2
==========================================
- Hits 12962 12958 -4
- Misses 1745 1751 +6 |
germa89
added a commit
that referenced
this pull request
Feb 14, 2025
* feat: allowing numpy types for setting parameters * docs: adding comment * chore: adding changelog file 3720.fixed.md [dependabot-skip] * fix: parameters length to 32+ * feat: update to 32 chars variable * fix: test --------- Co-authored-by: pyansys-ci-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace #3719
Issue linked
Close #3715
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)