-
Notifications
You must be signed in to change notification settings - Fork 135
Fixing numpy version #1709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
germa89
merged 11 commits into
main
from
fix/fix-numpy-version-to-avoid-deprecated-datatypes-calls
Dec 21, 2022
Merged
Fixing numpy version #1709
germa89
merged 11 commits into
main
from
fix/fix-numpy-version-to-avoid-deprecated-datatypes-calls
Dec 21, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please add one of the following labels to add this contribution to the Release Notes 👇 |
Codecov Report
@@ Coverage Diff @@
## main #1709 +/- ##
==========================================
- Coverage 85.26% 77.85% -7.42%
==========================================
Files 45 45
Lines 7506 7509 +3
==========================================
- Hits 6400 5846 -554
- Misses 1106 1663 +557 |
To be merged after the dev-docs action has been updated. |
Merging without coverage/ubuntu local test. |
2 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of:
https://github.com/pyansys/pymapdl/actions/runs/3730672637/jobs/6327994564#step:13:73
I need to fix the numpy version to 1.23.5 until VTK fix:
https://github.com/Kitware/VTK/blob/726ca7c45bef7de71254d2377c810d23612a56da/Wrapping/Python/vtkmodules/util/numpy_support.py#L74-L88