Adding Ubuntu docker image as remote #1636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add one of the following labels to add this contribution to the Release Notes 👇 |
Codecov Report
@@ Coverage Diff @@
## main #1636 +/- ##
==========================================
+ Coverage 82.81% 82.84% +0.02%
==========================================
Files 44 44
Lines 7151 7151
==========================================
+ Hits 5922 5924 +2
+ Misses 1229 1227 -2 |
germa89
changed the title
|
I was going to replace v22.2.0 with the ubuntu image, but I'm considering rebuilding the last 4 versions ( I know this will consume time. But I think we should keep the CentOS support for a while yet. |
koubaa
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding ubuntu docker image.
It seems our tests are too "CentOS" based.
Because I changed the file structure in the docker image (now the simulation is run in
/jobsinstead of/), some of the tests seems to fail when using the ubuntu image as remote. If you use it as local, it is fine.This PR aims to fix those and make the tests more general.