Skip to content

Improving error message in mapdl.get_value #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 30, 2022

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Aug 26, 2022

Improving command error message by falling back to mapdl.run("*get, ...") in mapdl._get (grpc version of get)

Close #1406

@germa89 germa89 self-assigned this Aug 26, 2022
@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #1413 (b022b95) into main (01d8f70) will increase coverage by 1.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1413      +/-   ##
==========================================
+ Coverage   76.76%   77.87%   +1.11%     
==========================================
  Files          43       44       +1     
  Lines        6878     7097     +219     
==========================================
+ Hits         5280     5527     +247     
+ Misses       1598     1570      -28     

Copy link
Collaborator

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one suggestion.

@germa89 germa89 merged commit db913df into main Aug 30, 2022
@germa89 germa89 deleted the feat/clearer-get-error-message branch August 30, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More clear error messages in *GET
2 participants