Adding database notes and some improvements #1392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Working on this I discovered this #1391 If enough feedback is given, I will fix 1391 in this PR too. |
Codecov Report
@@ Coverage Diff @@
## main #1392 +/- ##
==========================================
+ Coverage 76.71% 76.77% +0.06%
==========================================
Files 43 43
Lines 6870 6880 +10
==========================================
+ Hits 5270 5282 +12
+ Misses 1600 1598 -2 |
|
By the way, the docker image v22.2 seems to not support DB, but local installation does. Check: https://github.com/pyansys/pymapdl/runs/7972079545?check_suite_focus=true (First attempt) Pinging @dts12263 to see if he can build a new docker image with for 22.2 with working DB. |
akaszynski
reviewed
Aug 23, 2022
akaszynski
reviewed
Aug 23, 2022
akaszynski
reviewed
Aug 23, 2022
Co-authored-by: Alex Kaszynski <[email protected]>
akaszynski
approved these changes
Aug 23, 2022
germa89
added a commit
that referenced
this pull request
Sep 1, 2022
* Adding better version control checks to database. * Adding __repr__ method to node and elems classes * Moving the definion of __server_version to __init__ * Adding/improving unit tests * Adding documentation about database module * Adding string tests and removing 22.2 from CI testing * Fixing ON_CI import * Apply suggestions from code review Co-authored-by: Alex Kaszynski <[email protected]> Co-authored-by: Alex Kaszynski <[email protected]>
germa89
added a commit
that referenced
this pull request
Sep 1, 2022
* Adding better version control checks to database. * Adding __repr__ method to node and elems classes * Moving the definion of __server_version to __init__ * Adding/improving unit tests * Adding documentation about database module * Adding string tests and removing 22.2 from CI testing * Fixing ON_CI import * Apply suggestions from code review Co-authored-by: Alex Kaszynski <[email protected]> Co-authored-by: Alex Kaszynski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small improvements to database version checking and documentation.
Close #1325
Documentation view