Fixing order import #1386
Merged
Fixing order import #1386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also helps the autocomplete. |
|
Please add one of the following labels to add this contribution to the Release Notes 👇 |
|
The labeler AGAIN!!!!!!!! FML.... |
Haha! BTW, we fixed labeling in PyVista. See: https://github.com/pyvista/pyvista/blob/main/.github/workflows/label.yml |
akaszynski
approved these changes
Aug 22, 2022
Codecov Report
@@ Coverage Diff @@
## main #1386 +/- ##
==========================================
+ Coverage 76.64% 76.65% +0.01%
==========================================
Files 43 43
Lines 6860 6859 -1
==========================================
Hits 5258 5258
+ Misses 1602 1601 -1 |
The problem is not labeling (anymore... 🤞), it is the commenter. |
germa89
added a commit
that referenced
this pull request
Sep 1, 2022
* Fixing order import * fixing docstring for jupyter launch_mapdl * fixing circular import error. * Fixing coverage
germa89
added a commit
that referenced
this pull request
Sep 1, 2022
* Fixing order import * fixing docstring for jupyter launch_mapdl * fixing circular import error. * Fixing coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I did realize that VSCode was showing the wrong docstring info for
launch_mapdl, and it seems it is because of the import order.Before:
After: