Fix/lsread to non interactive #1384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also wrapping LSREAD in non-interactive context manager.
|
Thank you for the changes @akaszynski |
akaszynski
reviewed
Aug 22, 2022
Codecov Report
@@ Coverage Diff @@
## main #1384 +/- ##
==========================================
+ Coverage 76.64% 76.67% +0.02%
==========================================
Files 43 43
Lines 6860 6873 +13
==========================================
+ Hits 5258 5270 +12
- Misses 1602 1603 +1 |
akaszynski
approved these changes
Aug 22, 2022
germa89
added a commit
that referenced
this pull request
Sep 1, 2022
* Adding LSREAD to non-allowed interactive cmd Also wrapping LSREAD in non-interactive context manager. * Adding unit test. * Updating docs and docstring. * Double checking unit test. * Missing in. * add example; improve test * Fixing unit test * fixing unit test Co-authored-by: Alex Kaszynski <[email protected]>
germa89
added a commit
that referenced
this pull request
Sep 1, 2022
* Adding LSREAD to non-allowed interactive cmd Also wrapping LSREAD in non-interactive context manager. * Adding unit test. * Updating docs and docstring. * Double checking unit test. * Missing in. * add example; improve test * Fixing unit test * fixing unit test Co-authored-by: Alex Kaszynski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented LSREAD to run in
non_interactivemode if called asmapdl.lsreadIf called
mapdl.run("LSREAD,1")our outsidenon_interactivecontext manager, it will raise aRuntimeError.Close #1383 #1354