Skip to content

Copy method updated to handle copying of complex ApdlMathObj #1319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2022
Merged

Copy method updated to handle copying of complex ApdlMathObj #1319

merged 2 commits into from
Aug 7, 2022

Conversation

kmkoshy
Copy link
Contributor

@kmkoshy kmkoshy commented Aug 4, 2022

Complex ApdlMathObj using the copy method , Copies the real part and skips imaginary part.
Example :

image

Using Fz0 = Fz.copy()
Returns only the real part

image

@akaszynski
Copy link
Collaborator

Thanks for your contribution!

CI will this will fail, but I'll still check this locally and merge when it passes; I also want to add a test to make sure we cover this.

Copy link
Collaborator

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added complex test. Thanks for your work!

@akaszynski
Copy link
Collaborator

Approving and merging despite failing tests as this has been generated from a fork.

@kmkoshy, saw you're part of the ansys organization I've added you to the pyansys team. When you want to make another PR, ping me on teams and I'll add you to appropriate group so you'll have write access.

@akaszynski akaszynski merged commit 16d41ad into ansys:main Aug 7, 2022
@kmkoshy kmkoshy deleted the fix/copy-math-function branch August 8, 2022 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants