Skip to content

Adding exception when starting database in a non-valid MAPDL version #1286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jul 24, 2022

As requested in #1280

@germa89 germa89 added this to the v0.62.3 milestone Jul 24, 2022
@germa89 germa89 self-assigned this Jul 24, 2022
@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #1286 (ec0eba6) into main (32c2f72) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1286      +/-   ##
==========================================
+ Coverage   75.92%   75.93%   +0.01%     
==========================================
  Files          43       43              
  Lines        6780     6783       +3     
==========================================
+ Hits         5148     5151       +3     
  Misses       1632     1632              

Copy link
Collaborator

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Adding this to a patch milestone...

@akaszynski akaszynski modified the milestones: v0.62.3, v0.63.1 Jul 25, 2022
@akaszynski akaszynski merged commit aaa392e into main Jul 25, 2022
@akaszynski akaszynski deleted the feat/raise-exception-if-using-database-in-invalid-grpc-api-versions branch July 25, 2022 03:38
germa89 added a commit that referenced this pull request Sep 1, 2022
…1286)

* Adding exception when starting database in a non-valid MAPDL version

* removing test and using pragma. For some reason, the test crashes my MAPDL session.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants