Skip to content

Download error page and helper #1283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 23, 2022
Merged

Download error page and helper #1283

merged 5 commits into from
Jul 23, 2022

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jul 22, 2022

Adding download section:

image

And also adding a helper:

def _download_file(filename, directory=None):
    url = _get_file_url(filename, directory)
    try:
        return _retrieve_file(url, filename)
    except Exception as e:  # Genering exception
        raise Exception(
            "For the reason mentioned below, retrieving the file from internet failed.\n"
            "You can download this file from:\n"
            f"{url}\n"
            "\n"
            "The reported error message is:\n"
            f"{str(e)}"
        )

Close #1156

@germa89 germa89 self-assigned this Jul 22, 2022
Copy link
Collaborator

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding this!

@akaszynski akaszynski enabled auto-merge (squash) July 23, 2022 00:30
@codecov
Copy link

codecov bot commented Jul 23, 2022

Codecov Report

Merging #1283 (3d2f580) into main (8493c2f) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1283      +/-   ##
==========================================
+ Coverage   75.86%   75.88%   +0.02%     
==========================================
  Files          43       43              
  Lines        6765     6768       +3     
==========================================
+ Hits         5132     5136       +4     
+ Misses       1633     1632       -1     

@akaszynski akaszynski merged commit 8b9e5f2 into main Jul 23, 2022
@akaszynski akaszynski deleted the feat/download-error-helper branch July 23, 2022 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download page option
2 participants