Skip to content

Using global logger in licensing #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2022
Merged

Using global logger in licensing #1259

merged 2 commits into from
Jul 8, 2022

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jul 7, 2022

We should just reuse the general logger created when the module is imported.

@germa89 germa89 added this to the v0.62.2 milestone Jul 7, 2022
@germa89 germa89 self-assigned this Jul 7, 2022
@github-actions github-actions bot added the BUG label Jul 7, 2022
@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #1259 (062f51d) into main (2f0203a) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1259      +/-   ##
==========================================
- Coverage   78.02%   78.01%   -0.01%     
==========================================
  Files          43       43              
  Lines        6780     6778       -2     
==========================================
- Hits         5290     5288       -2     
  Misses       1490     1490              

@germa89 germa89 enabled auto-merge (squash) July 8, 2022 10:38
@germa89 germa89 merged commit 9007fb4 into main Jul 8, 2022
@germa89 germa89 deleted the fix/wrong-log-import branch July 8, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants