Fix/commenter

[germa89]

I discover in #1155 that the commenter wasn't working.

Close #1155

[github-actions]

Please add one of the following labels to add this contribution to the Release Notes 👇

• BUG
• NEW FEATURE
• Enhancement
• Documentation
• Examples
• Maintenance
• CI/CD

[germa89]

Solution

The reason was the if evaluation. We had:

if: toJSON(github.event.pull_request.labels.*.name) == '{}'

But it should be:

if: toJSON(github.event.pull_request.labels.*.name) == '[]'

Tests

I did a test in:
5aef9cc

with:

    - name: Test
      run: |
        toJSON(github.event.pull_request.labels.*.name)
        ${{ toJSON(github.event.pull_request.labels.*.name) }}

and the result was:

https://github.com/pyansys/pymapdl/runs/7229660105?check_suite_focus=true

Notes

Pinging @jorgepiloto for review and for awareness.
Pinging @RobPasMue because it is good piece of info (evaluation of info in Github tends to return lists (square brackets))

[codecov]

Codecov Report

Merging #1258 (dbedd16) into main (6498dff) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1258   +/-   ##
=======================================
  Coverage   78.02%   78.02%           
=======================================
  Files          43       43           
  Lines        6780     6780           
=======================================
  Hits         5290     5290           
  Misses       1490     1490           

[RobPasMue]

Ha... Thanks for the update! I think it makes sense that it returns a list rather than brackets... YAML files work with lists. Plus, brackets are used for interpreting variables in the GitHub workflow... which makes sense that you would try to avoid and return a bracketed string.

JSON also works with square brackets for representing lists. In fact, what it must be happening is that all this information is (behind the scenes) a complete JSON file, and you must be accessing elements by calling github.event.pull_request.labels.*.name which will return the value for a key. By placing the asterisk in the call, you are forcing all the values to be represented in a list. And a JSON list is also in square brackets so, it just makes sense :)

Thanks for the info @germa89!! =)

[germa89]

Ha... Thanks for the update! I think it makes sense that it returns a list rather than brackets... YAML files work with lists. Plus, brackets are used for interpreting variables in the GitHub workflow... which makes sense that you would try to avoid and return a bracketed string.

JSON also works with square brackets for representing lists. In fact, what it must be happening is that all this information is (behind the scenes) a complete JSON file, and you must be accessing elements by calling github.event.pull_request.labels.*.name which will return the value for a key. By placing the asterisk in the call, you are forcing all the values to be represented in a list. And a JSON list is also in square brackets so, it just makes sense :)

Masterclass over here! This should be in the Github docs. 😄