Cancel old ongoing workflows #1216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
CI/CD
Codecov Report
@@ Coverage Diff @@
## main #1216 +/- ##
=======================================
Coverage 78.02% 78.02%
=======================================
Files 43 43
Lines 6777 6777
=======================================
Hits 5288 5288
Misses 1489 1489 |
|
Looks like CI finally passed (after multiple retries). Ready to be reviewed @germa89 @akaszynski. |
germa89
approved these changes
Jun 21, 2022
There was a problem hiding this comment.
Very nice addition. Thank you very much @RobPasMue ! Good job!
*I'm leaving this so @akaszynski can merge it. This is very good to be implemented in other projects.
Fully agree. @RobPasMue, please open an issue in the dev-guide and write it down. |
|
@RobPasMue this not affect code static analyzer. I don't think it is a big deal (I wouldn't bother to change that) but I just want to leave paper trace about that. Otherwise good job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These lines of code will basically cancel pre-existing workflows once you upload new changes, and will avoid running unnecessary workflows.
Use case:
In these circumstances, it is more than probable that you will have two workflows running on parallel, though you are not interested in the older one. This way, GitHub cancels the old workflow and just retains the new one.