Skip to content

fix reset cache without pyvista #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 1, 2022
Merged

fix reset cache without pyvista #1153

merged 2 commits into from
Jun 1, 2022

Conversation

koubaa
Copy link
Contributor

@koubaa koubaa commented May 31, 2022

Fixes #1152

@koubaa koubaa requested a review from germa89 May 31, 2022 19:28
@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #1153 (1c189b1) into main (263222d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1153      +/-   ##
==========================================
+ Coverage   77.97%   77.98%   +0.01%     
==========================================
  Files          43       43              
  Lines        6760     6764       +4     
==========================================
+ Hits         5271     5275       +4     
  Misses       1489     1489              

Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you!

@germa89 germa89 merged commit 11ce5a4 into main Jun 1, 2022
@germa89 germa89 deleted the reset-cache-without-pyvista branch June 1, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run() without pyvista leads to an unecessary warning
2 participants