Turn machine lists into Fluent parallel options #850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnwillia-work
force-pushed
the
feat/scheduler
branch
from
5f1c018 to
9e21650
Compare
dnwillia-work
changed the title
mkundu1
approved these changes
Sep 7, 2022
seanpearsonuk
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing this on SLURM, these small changes to MachineList make the arguments construction a bit more straightforward. I've added support for
len()and indexing operation. The function to build the parallel arguments is added to the main package and is tested.From here one would need to call these functions in launch_fluent. I'll try this next.