Skip to content

Added health check and upload download methods made public #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hpohekar
Copy link
Collaborator

@hpohekar hpohekar commented Sep 5, 2022

No description provided.

@seanpearsonuk
Copy link
Collaborator

seanpearsonuk commented Sep 5, 2022

test_create_session_from_server_info_file_with_wrong_password:

def test_create_session_from_server_info_file_with_wrong_password(
    tmp_path: Path,
) -> None:
    # ...
    session = _BaseSession.create_from_server_info_file(
        server_info_filepath=str(server_info_file), cleanup_on_exit=False
    )
    assert session.check_health() == HealthCheckService.Status.NOT_SERVING.name

Now we are raising an exception in this scenario. So the test is failing. The raise behaviour is the only viable design alternative so the test needs to be updated with this PR.

See uses of with pytest.raises(RuntimeError): in tests/

@hpohekar
Copy link
Collaborator Author

hpohekar commented Sep 5, 2022

test_create_session_from_server_info_file_with_wrong_password:

def test_create_session_from_server_info_file_with_wrong_password(
    tmp_path: Path,
) -> None:
    # ...
    session = _BaseSession.create_from_server_info_file(
        server_info_filepath=str(server_info_file), cleanup_on_exit=False
    )
    assert session.check_health() == HealthCheckService.Status.NOT_SERVING.name

Now we are raising an exception in this scenario. So the test is failing. The raise behaviour is the only viable design alternative so the test needs to be updated with this PR.

See uses of with pytest.raises(RuntimeError): in tests/

Right, Thank you.

@hpohekar hpohekar merged commit 1e45d08 into main Sep 5, 2022
@hpohekar hpohekar deleted the fix/health_checking_changes_public_upload_download_methods branch September 5, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants