Skip to content

Add accessor methods for argument subitems #832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 5, 2022
Merged

Add accessor methods for argument subitems #832

merged 6 commits into from
Sep 5, 2022

Conversation

prmukherj
Copy link
Collaborator

@prmukherj prmukherj commented Sep 4, 2022 •
edited by seanpearsonuk
Loading

Remaining work:

  1. Apply methods to argument sub-items - nested arguments. N.b limitation remains for singleton/model object arguments, for which update of gRPC is needed in further work.
  2. Add unit-tests for sub-items - nested arguments check

This was linked to issues Sep 4, 2022
explicit attribute methods of argument sub-items #786
Closed
add missing journalable data model methods #811
Closed
@prmukherj prmukherj marked this pull request as ready for review September 5, 2022 13:35
@prmukherj prmukherj merged commit 4022012 into main Sep 5, 2022
@prmukherj prmukherj deleted the maint/attr_methods_in_arg_subitems branch September 5, 2022 14:34
@prmukherj prmukherj linked an issue Sep 5, 2022 that may be closed by this pull request
Make TaskObject.CommandArguments read-only #824
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanpearsonuk seanpearsonuk seanpearsonuk approved these changes

@hpohekar hpohekar hpohekar approved these changes

@mkundu1 mkundu1 Awaiting requested review from mkundu1 mkundu1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make TaskObject.CommandArguments read-only add missing journalable data model methods explicit attribute methods of argument sub-items
3 participants
@prmukherj @seanpearsonuk @hpohekar