Add icing session type with datamodel #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

lagacep-ans merged 11 commits into main from feat/datamodel-icing-2

Sep 1, 2022

Contributor

lagacep-ans commented Aug 23, 2022 •

edited

Loading

New SolverIcing session type, similar to Solver but with the flserver datamodel enabled and linked to the icing attribute. Fluent is launched with the -flicing command line option.

To use the icing datamodel, a datamodelgen is required with v231/fluent/ pointed by PYFLUENT_FLUENT_ROOT

Usage scenario is as:

session = pyfluent.launch_fluent(mode="solver-icing")
csim = session.icing
# Below code is the same as icing client python journaling
csim.Ice.IceConditions.IcingAirTemperature = 275.
csim.Solution.IceRun.Calculate()

lagacep-ans added 4 commits

August 19, 2022 10:25


          Add SolverIcing session type and related launcher/datamodelgen changes

d82c31a


          Merge remote-tracking branch 'origin/main' into feat/datamodel-icing-2

44eb95c


          cleanup

e495210


          failsafe for missing icing datamodel , flake8/pre-commit cleanup

47436cb

lagacep-ans requested review from prmukherj, mkundu1 and seanpearsonuk

August 23, 2022 15:59

lagacep-ans commented

View reviewed changes

codegen/datamodelgen.py Outdated Show resolved Hide resolved

lagacep-ans commented

View reviewed changes

codegen/datamodelgen.py Outdated Show resolved Hide resolved

lagacep-ans commented

View reviewed changes

codegen/datamodelgen.py Show resolved Hide resolved

lagacep-ans commented

View reviewed changes

src/ansys/fluent/core/launcher/launcher.py Show resolved Hide resolved

lagacep-ans commented

View reviewed changes

src/ansys/fluent/core/launcher/launcher.py Show resolved Hide resolved

lagacep-ans commented

View reviewed changes

src/ansys/fluent/core/launcher/launcher.py Show resolved Hide resolved

seanpearsonuk approved these changes

View reviewed changes

dnwillia-work reviewed

View reviewed changes

src/ansys/fluent/core/session_solver_icing.py Outdated Show resolved Hide resolved

lagacep-ans added 3 commits

August 24, 2022 16:42


          command line argument for codegen, to permit version switching withou…

ea78a02

…t env var


          fix comment

ccd5e65


          clarification for fluent path

836e0f6

lagacep-ans commented

View reviewed changes

codegen/allapigen.py Show resolved Hide resolved

lagacep-ans marked this pull request as ready for review

August 24, 2022 23:32


          Merge branch 'main' into feat/datamodel-icing-2

f58df2c

dnwillia-work approved these changes

View reviewed changes

lagacep-ans and others added 2 commits

August 29, 2022 10:06


          Merge branch 'main' into feat/datamodel-icing-2

0e62119


          fix icing datamodel for the newly added v222/v231 version storage.

416fc0e

lagacep-ans mentioned this pull request

Cleanup pyfluent.EXAMPLES_PATH before running unittest job #791

Closed


          cleanup and more general version check in datamodelgen for icing

b8e29c5

mkundu1 approved these changes

View reviewed changes

mkundu1 closed this

mkundu1 reopened this

Contributor

mkundu1 commented Sep 1, 2022

I gave the CI a rerun as I've renamed one of the CI job.

lagacep-ans merged commit e092785 into main

lagacep-ans deleted the feat/datamodel-icing-2 branch

September 1, 2022 15:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dnwillia-work dnwillia-work approved these changes

seanpearsonuk seanpearsonuk approved these changes

mkundu1 mkundu1 approved these changes

prmukherj Awaiting requested review from prmukherj prmukherj is a code owner

Labels

None yet