-
Notifications
You must be signed in to change notification settings - Fork 13
FEAT: Via clustering extending line support #953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/pyedb/dotnet/edb_core/edb_data/hfss_pi_simulation_setup_data.py # src/pyedb/dotnet/edb_core/utilities/simulation_setup.py
# Conflicts: # src/pyedb/dotnet/edb_core/components.py
# Conflicts: # src/pyedb/dotnet/edb_core/padstack.py
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #953 +/- ##
==========================================
+ Coverage 82.67% 82.69% +0.01%
==========================================
Files 160 160
Lines 21120 21115 -5
==========================================
- Hits 17462 17461 -1
+ Misses 3658 3654 -4 |
hui-zhou-a
requested changes
Jan 13, 2025
hui-zhou-a
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
grpc-transition
Changes that need to be included in gRPC transition
testing
Anything related to testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New HFSS 3D layout extension managing via clustering. It interacts both with AEDT and PyEDB.
After opening the UI the tool creates a specific layer where the users can draw polygons and rectangle to select areas where via have to be merged. Once processed in EDB the new project is open in AEDT.