Skip to content

FEAT: hole override #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 14, 2024
Merged

FEAT: hole override #849

merged 2 commits into from
Oct 14, 2024

Conversation

hui-zhou-a
Copy link
Collaborator

No description provided.

@hui-zhou-a hui-zhou-a linked an issue Oct 9, 2024 that may be closed by this pull request
Add ..."hole_diameter" in pyedb.dotnet.edb_core.edb_data.padstacks_data.EDBPadstackInstance #723
Closed
@github-actions github-actions bot added the testing Anything related to testing label Oct 9, 2024
@hui-zhou-a hui-zhou-a added grpc-transition Changes that need to be included in gRPC transition and removed testing Anything related to testing labels Oct 9, 2024
svandenb-dev
svandenb-dev approved these changes Oct 12, 2024
View reviewed changes
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SMoraisAnsys
SMoraisAnsys approved these changes Oct 13, 2024
View reviewed changes
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
As you mentioned in a comment of a previous PR, get returns None by default. We might want to update the code to avoid .get("...", None) pattern.

@hui-zhou-a hui-zhou-a merged commit 3e87301 into main Oct 14, 2024
29 checks passed
@hui-zhou-a hui-zhou-a deleted the feat-hole-override branch October 14, 2024 07:33
@svandenb-dev svandenb-dev mentioned this pull request Mar 17, 2025
Draft
59 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svandenb-dev svandenb-dev svandenb-dev approved these changes

@SMoraisAnsys SMoraisAnsys SMoraisAnsys approved these changes

Assignees
No one assigned
Labels
grpc-transition Changes that need to be included in gRPC transition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ..."hole_diameter" in pyedb.dotnet.edb_core.edb_data.padstacks_data.EDBPadstackInstance
3 participants
@hui-zhou-a @svandenb-dev @SMoraisAnsys