FIX: Update unit tests to be compatible with upcoming pyedb-core pre-release package #1314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewm102
commented
Jun 26, 2025
| @@ -800,8 +800,8 @@ def test_stackup_place_on_top_of_lam_with_mold_solder(self): | |||
| assert cellInstance.Is3DPlacement() | |||
| if chipEdb.grpc: | |||
| transform = cellInstance.transform3d | |||
There was a problem hiding this comment.
Soldberball properties for ComponentType.OTHER were fixed in this PR. These unit tests had to be updated to reflect these changes (let me know if this doesn't seem right to you though)
There was a problem hiding this comment.
I don't see Solderballs involved in this test. Should it be another ?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1314 +/- ##
=======================================
Coverage 75.87% 75.87%
=======================================
Files 163 163
Lines 23838 23838
=======================================
Hits 18086 18086
Misses 5752 5752 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update unit tests to be compatible with upcoming pyedb-core pre-release package v0.2.0.dev5