Skip to content

FEAT: Compare edbs #1311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

FEAT: Compare edbs #1311

wants to merge 25 commits into from

Conversation

gkorompi
Copy link
Collaborator

No description provided.

@gkorompi gkorompi requested a review from svandenb-dev June 26, 2025 07:39
@gkorompi gkorompi linked an issue Jun 26, 2025 that may be closed by this pull request
@github-actions github-actions bot added the testing Anything related to testing label Jun 26, 2025
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add also gor gRPC ?

gkorompi and others added 3 commits June 26, 2025 10:51
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2025

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.85%. Comparing base (eee22d4) to head (819dc86).

❌ Your patch status has failed because the patch coverage (84.61%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1311      +/-   ##
==========================================
- Coverage   75.87%   75.85%   -0.02%     
==========================================
  Files         163      163              
  Lines       23838    23848      +10     
==========================================
+ Hits        18086    18090       +4     
- Misses       5752     5758       +6     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gkorompi gkorompi requested a review from svandenb-dev June 26, 2025 08:15
@gkorompi gkorompi changed the title Compare edbs FEAT: Compare edbs Jun 26, 2025
svandenb-dev
svandenb-dev previously approved these changes Jun 26, 2025
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Anything related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create compare two edbs function
3 participants