CHORE: Ansys version warning vs grpc #1294
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/pyedb/grpc/database/layout/layout.py
# Conflicts: # src/pyedb/configuration/cfg_setup.py
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1294 +/- ##
==========================================
- Coverage 75.79% 75.76% -0.03%
==========================================
Files 163 163
Lines 23908 23921 +13
==========================================
+ Hits 18120 18123 +3
- Misses 5788 5798 +10 🚀 New features to boost your workflow:
|
gkorompi
approved these changes
Jun 20, 2025
SMoraisAnsys
approved these changes
Jun 20, 2025
Comment on lines
+120
to
+125
| warnings.warn("Your ANSYS AEDT version is eligible to gRPC version", UserWarning) | ||
| warnings.warn("gRPC is not enabled by default, however you might consider using this version", UserWarning) | ||
| warnings.warn("Please check online documentation for more information", UserWarning) | ||
| warnings.warn("gRPC is offering better stability and compatibility with Linux", UserWarning) | ||
| warnings.warn("Note: current DotNet PyEDB will be deprecated starting release 2026.1", UserWarning) | ||
| warnings.warn("New feature will only be implemented in gRPC version", UserWarning) |
There was a problem hiding this comment.
Suggested change
| warnings.warn("Your ANSYS AEDT version is eligible to gRPC version", UserWarning) | |
| warnings.warn("gRPC is not enabled by default, however you might consider using this version", UserWarning) | |
| warnings.warn("Please check online documentation for more information", UserWarning) | |
| warnings.warn("gRPC is offering better stability and compatibility with Linux", UserWarning) | |
| warnings.warn("Note: current DotNet PyEDB will be deprecated starting release 2026.1", UserWarning) | |
| warnings.warn("New feature will only be implemented in gRPC version", UserWarning) | |
| warnings.warn("Your ANSYS AEDT version is eligible to gRPC version", UserWarning) | |
| warnings.warn("gRPC is not enabled by default, however you might consider using this version", UserWarning) | |
| warnings.warn("Please check online documentation for more information", UserWarning) | |
| warnings.warn("gRPC is offering better stability and compatibility with Linux", UserWarning) | |
| warnings.warn("Note: current DotNet PyEDB will be deprecated starting release 2026.1", UserWarning) | |
| warnings.warn("New feature will only be implemented in gRPC version", UserWarning) |
Can you shorten the message and provide the link to the gRPC documentation ?
Comment on lines
+127
to
+134
| if grpc: | ||
| warnings.warn( | ||
| f"gRPC flag was enabled however your ANSYS AEDT version {edbversion} is not compatible", UserWarning | ||
| ) | ||
| warnings.warn( | ||
| f"Disabling gRPC, you might consider upgrading your ANSYS version for better experience", UserWarning | ||
| ) | ||
| grpc = False |
There was a problem hiding this comment.
Any reason to switch grpc value instead of directly raising an error ?
There was a problem hiding this comment.
You prefer breaking and warn user ? ok for me too
There was a problem hiding this comment.
I would avoid changing the input provided by the user yeah. I think that, by default, grpc is equal to False so if it's True then the user should strongly be notified about this limitation. Otherwise you might endup with people missing the warning and thinking that gRPC didn't change anything compared to the previous approach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding deprecation warning with respect to PyEDB DotNet vs gRPC.